Impersonation Cleanup#1309
Merged
tabascq merged 2 commits intoPuzzleServer:mainfrom Mar 11, 2026
Merged
Conversation
Contributor
tabascq
commented
Mar 1, 2026
tabascq
commented
- Disallow switching out of co-op mode when impersonating. (Fixes Force co-op mode in impersonation #1300)
- Review all uses of GetTeamForPlayer and approve/fix most of them. Oustanding cases are in CustomHtmlPageLoader and SyncController, which do not really have any way to access EventRole; we may need to put teamID/password in the queryString for these cases. (partial for Impersonation-proof all uses of UserEventHelper.GetTeamForPlayer #1299)
- Disallow switching out of co-op mode when impersonating. (Fixes PuzzleServer#1300) - Review all uses of GetTeamForPlayer and approve/fix most of them. Oustanding cases are in CustomHtmlPageLoader and SyncController, which do not really have any way to access EventRole; we may need to put teamID/password in the queryString for these cases. (partial for PuzzleServer#1299)
CustomHtmlPageLoader never actually used the Team object so I just removed that line of code. The [PlayerCanSeePuzzle] auth check on this controller is sufficient to allow access when impersonating. SyncController can be handled by putting the teamPassword into the queryString; also updating the FileUploadHelper to provide this queryString by default.
Contributor
Author
|
The last two cases are now handled. |
morganbr
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.