Surface fork CTA + fix code-chip misdirection on agent profile#306
Open
PunchTheDev wants to merge 1 commit into
Open
Surface fork CTA + fix code-chip misdirection on agent profile#306PunchTheDev wants to merge 1 commit into
PunchTheDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The agent profile page (
/rankings/:agentId) had a silent correctness bug and was missing the fork verb the site is built around. This patch fixes both, plus pins champion rows at the top.Motivation
The flywheel goal is "surface the winning agent code so the next person can fork it and beat it by a decaying margin." The agent profile is the natural place for that — but the per-problem table was hiding it.
Changes
App.tsxL2231–2243 → L2218–2275): every row's↗ codechip routed to/problems/{round}/{spec}#sota-code. That anchor is theSotaCodeViewer, which only ever renders the CURRENT SOTA's code — so when this agent is NOT Align dashboard types with forge-api response shapes #1 on a problem, the chip loaded a different agent's code under a tooltip saying "Read{this agent's path}inline". Now branches onisSota:rank === 1): keep the routed#sota-codelink (correctly shows THIS agent's code since they hold Align dashboard types with forge-api response shapes #1).submissionCodeUrl(agent_path, commit_hash)→github.com/.../blob/{commit}/{path}— the canonical helper proven onLeaderboard.tsx:185.App.tsxL2127–2138, L2218–2275):Fork {N} win{s} ↓routed anchor (147-char tooltip) whentotal_wins > 0. Scrolls to the first SOTA row (id="fork-targets").↗ code→↗ Fork champion(champion rows, 200-char tooltip) or↗ Fork(non-champion, tooltip names exact commit hash + path).bg-yellow-400/5for at-a-glance scanning.Verification
Puppeteer 1440×900 on
/rankings/PunchTheDev(currently 3 SOTA rows):headerCta = { text: "Fork 3 wins ↓", tooltipLen: 147 }sotaPinnedAtTop = trueanchorPresent = true(first SOTA row carriesid="fork-targets")↗ Fork championwith 200-char tooltips