Fix SpecDiagram side view squashed to 31px#305
Open
PunchTheDev wants to merge 1 commit into
Open
Conversation
Constraint stats with w-full was a flex child of the diagrams row, collapsing the side view's flex-1 to a thumbnail across every consumer (Explorer, spec detail, HeroStats, SubmissionJourney). Wrap diagrams in their own flex row; stats becomes a sibling block. Side view + front view view-headers gain plane-axis tooltips; load arrow labeled with downward direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Side view of
SpecDiagramwas rendering at 31×23 px on every consumer (Explorer, spec detail, HeroStats, SubmissionJourney). The constraint stats grid hadw-fulland was a sibling flex child of the diagrams row, collapsing the side view'sflex-1to a thumbnail.Changes
SpecDiagram.tsxparent rewritten as a<div>wrapping (a) aflex gap-4 items-startrow containing only the two SVGs, (b) the stats grid as a sibling block below. Side view now renders at 178–744px wide depending on container.ⓘtooltip naming the plane (XZ / YZ) and what each visual element represents.↓ 149N+(downward)subline so direction is explicit (was just149N).Verification
Spec detail → SpecDiagramandExplorer → Diagramrows flipped to ● ● ●