Replace invented Guide patterns loop with canonical 3-phase#300
Open
PunchTheDev wants to merge 1 commit into
Open
Replace invented Guide patterns loop with canonical 3-phase#300PunchTheDev wants to merge 1 commit into
PunchTheDev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites
Guide → Agent architecture patternsagainst the canonical source agents. The section previously claimed "best agents use a structured observe → plan → act loop rather than a single prompt" and showed a 6-phase loop (OBSERVE→PLAN→ACT→VERIFY→REFLECT→EXPORT) plus four library tiles, half of which are not used by any canonical agent.Motivation
Audit against
forge/agents/andforge/examples/:agents/baseline/agent.pyis deterministic geometry, no LLM call. Docstring is explicit: "This agent accepts the LLMClient parameter but does not use it … This is permitted; the harness requires the parameter to be present in the signature, not necessarily used." Guide framing ("best agents use a loop") implied this is wrong — it's actually one of two legitimate patterns.examples/llm-agent/agent.pyuses literal 3-phase comments:── Observe ──,── Plan (LLM proposes dimensions) ──,── Act (build geometry) ──. The Guide's 6-phase loop with VERIFY + REFLECT + EXPORT is not in any canonical agent.gmshandnumpy/scipyare not imported by any agent inagents/orexamples/. Onlybuild123d(both LLM examples) and raw OCP (baseline) are verified.examples/llm-agent/andexamples/metric-aware-agent/— the references the template literally tells users to read — were never linked from the Guide.LLMClient.chat(messages, max_tokens=...)API was never surfaced.Pattern matches steps 359 / 365 / 367 / 368 / 369 / 370 / 371 / 372 / 373 — canonical-source check before tooltip / before claim.
Changes
QuickstartGuide.tsxL639–743: lead reframed as "two canonical patterns, pick one" rather than "best agents use a loop"agents/baseline/agent.py, 247-char tooltip quoting the baseline docstring verbatimexamples/llm-agent/agent.pybuild_volume_mm,load_point_mm,bolt_pattern_mm,min_wall_thickness_mm) and the actualllm.chat([{"role":"user","content": prompt}], max_tokens=256)call fromexamples/llm-agent/agent.py:53forge/sdk/llm.pyand tying back to the Whitelisted models sectionbuild123d(recommended, used by both LLM examples) andRaw OCP (BRep)(used by baseline). Each tile gets a tooltip citing the specific OCP / build123d imports in the canonical files.gmshandnumpy/scipytiles removed (not used by any canonical agent).examples/llm-agent/agent.py,examples/metric-aware-agent/agent.py,agents/baseline/agent.pyVerification: Puppeteer 1440×900 on
/guide#patternsconfirms 5 tooltips (lengths 247/200/213/176/135), 3 GitHub links pointing at the right files, old 6-phase / gmsh / numpy claims all gone, canonical 3-phase OBSERVE/PLAN/ACT +llm.chat(API + all 3 reference agent paths present. 0 new console errors (1 pre-existing 404).