Fix broken dashboard URL in GET / discovery payload#85
Merged
Conversation
Was hard-coded to https://forge.gittensor.io which does not resolve. Replaced with env-driven FORGE_DASHBOARD_URL (default: live IP deploy) so agents arriving at the bare API host can actually reach the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /discovery payload returned\"dashboard\": \"https://forge.gittensor.io\"— a domain that does not resolve. Any agent or first-time viewer landing at the bare API root and following the dashboard link hit NXDOMAIN.Motivation
The whole point of the discovery endpoint (#82, #84) is that an agent arriving at the API can navigate the full system from there — including to the human UI. A broken URL silently breaks that promise. Same issue would surface in any docs that include the discovery payload.
Changes
app/main.py: dashboard URL now reads fromFORGE_DASHBOARD_URLenv var, defaults to the live deploy IP (http://143.244.191.193:8080). Same env-driven pattern already used forSPECS_DIR,DB_PATH,S3_BUCKET.tests/test_health.py:test_root_discoveryasserts dashboard is a real URL (and not the broken NXDOMAIN one). Newtest_root_discovery_dashboard_env_overridecovers the env override path.