Modify the percentage display for Tracker docker implementation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanrabey
reviewed
Oct 21, 2022
| $this->_consoleOutput->overwrite($bar, 0); | ||
| $percent = ($complete * 100); | ||
| $bar .= str_pad($percent . '%', $numberLen, ' ', STR_PAD_LEFT); | ||
| if ($percent % 10 === 0 && $percent !== $logged_percentage) { |
There was a problem hiding this comment.
What is this check for @JINGJINGTANG ?
$percent !== $logged_percentage
Collaborator
Author
There was a problem hiding this comment.
This is to make sure we are only logging the same progress (percentage) once to the log file. Since we are logging the progress to a log file, we can't have it overwritten the previous log. Thus, we are logging 0%, 10%, 20%...etc
Collaborator
Author
There was a problem hiding this comment.
In the mcap parse, we would have this inside the for loop: $logged_percentage = $progress->draw($logged_percentage);
seanrabey
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.