feat(BE-47): unified Soroban contract error mapping (#506)#512
Merged
Conversation
Map Soroban contract failures to stable API error codes so frontend/mobile can show clear, consistent error UX. - Add SorobanErrorCode enum covering auth, pause, escrow state, balance, version mismatch, admin, input validation, budget, and unknown errors - Implement mapSorobanError() replacing the old mapSimulationError() with stable codes clients can switch on - Wire transaction.service to use the new mapper; RESTORE_REQUIRED now uses SorobanErrorCode enum value - Add 30 unit tests covering all top-level contract error scenarios plus unknown/unexpected failures - request_id is always present via GlobalHttpExceptionFilter (unchanged) Closes Pulsefy#506
|
@Nonso-Eze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Cedarich
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map Soroban contract failures to stable API error codes so frontend/mobile can show clear, consistent error UX.
Closes #506