Implement fee configuration constraints with hard bounds and rounding…#494
Closed
iyanumajekodunmi756 wants to merge 1 commit into
Closed
Implement fee configuration constraints with hard bounds and rounding…#494iyanumajekodunmi756 wants to merge 1 commit into
iyanumajekodunmi756 wants to merge 1 commit into
Conversation
… guarantees - Add MAX_FEE_BPS constant (1000 = 10%) to prevent excessive fee configuration - Enforce maximum fee constraints in set_fee_config and set_per_asset_fee functions - Implement deterministic floor division rounding for fee calculations - Add comprehensive tests for extreme fee values and edge cases - Add tests for small-amount fee calculations and rounding determinism - Improve documentation with rounding behavior details This addresses issue Pulsefy#435 by ensuring fee config cannot exceed safe limits, fees are deterministic and tested across assets, and providing proper validation. Generated with [Devin](https://cli.devin.ai/docs) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
@iyanumajekodunmi756 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Fix workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… guarantees
This addresses issue #435 by ensuring fee config cannot exceed safe limits, fees are deterministic and tested across assets, and providing proper validation.
Generated with Devin
closes #435