-
-
Notifications
You must be signed in to change notification settings - Fork 388
fix: allow dead hardcore players to move as ghosts #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: general-devel
Are you sure you want to change the base?
Conversation
e5111f4 to
c81936f
Compare
c81936f to
c0b860c
Compare
c0b860c to
abe3f29
Compare
|
Could this PR also make changes to |
|
I've gone through a list of packets that should be entirely ignored from dead players at all times (based on PacketTypes enum):
The following should ideally be rejected if
I'm not entirely sure if all of these have handlers in GetDataHandlers. But this list should hopefully be everything a dead player should be unable to do, that a malicious client would try to abuse. It's a bit risky to allow a lot of these from a dead player. |
Fixed hardcore ghosts don't move server-side
HandlePlayerKillMeV2, set the player's dead state to true:TShock/TShockAPI/GetDataHandlers.cs
Lines 4325 to 4326 in a867772
OnGetData, most packets from "dead" ghost players are filtered out, so the server cannot detect player movement and fails to send the correctTileSquarepacket.TShock/TShockAPI/TShock.cs
Lines 1643 to 1648 in a867772