fix(ci): make CI green on main — lockfile, SPDX headers, doctor key, lint#20
Merged
Conversation
…lint
Three independent root causes were turning CI red on main:
- test (3.11/3.12): `uv sync` failed resolving a stale `uv.lock`. The lock
pinned an old OperationsCenter commit whose transitive dependency name
(`executor-runtime`) no longer matched the upstream package's renamed
metadata (`core-runner`), so uv aborted with a name-mismatch error.
Regenerated the lock (`uv lock --upgrade`) to track current upstream,
which now resolves `core-runner` from its renamed source. This also
unmasked latent ruff failures the install error had been hiding:
- I001/F401 import sorting + unused imports: applied ruff --fix.
- B017 (`pytest.raises(Exception)`): narrowed to `pydantic.ValidationError`,
the exception these frozen-model / validation tests actually assert.
- License headers: two empty package-init files lacked the SPDX header.
Added the repo's exact two-line `AGPL-3.0-or-later` header to
test/unit/switchboard/__init__.py and .../contracts/__init__.py.
- Custodian doctor: `audit.reconcile_enforce` is consumed by the R1/R2
reconcile detector but is absent from custodian-doctor's built-in
known-audit-key list, producing a spurious "unknown audit key" warning
under --strict. Declared it via `plugin_audit_keys` (the documented
escape hatch); the key stays active, no check is disabled.
Verified locally (Python 3.11): uv sync, ruff check src test,
pytest (347 passed), check_docs.sh, and custodian-doctor --strict all pass.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three independent root causes were turning CI red on main:
test (3.11/3.12):
uv syncfailed resolving a staleuv.lock. The lockpinned an old OperationsCenter commit whose transitive dependency name
(
executor-runtime) no longer matched the upstream package's renamedmetadata (
core-runner), so uv aborted with a name-mismatch error.Regenerated the lock (
uv lock --upgrade) to track current upstream,which now resolves
core-runnerfrom its renamed source. This alsounmasked latent ruff failures the install error had been hiding:
pytest.raises(Exception)): narrowed topydantic.ValidationError,the exception these frozen-model / validation tests actually assert.
License headers: two empty package-init files lacked the SPDX header.
Added the repo's exact two-line
AGPL-3.0-or-laterheader totest/unit/switchboard/init.py and .../contracts/init.py.
Custodian doctor:
audit.reconcile_enforceis consumed by the R1/R2reconcile detector but is absent from custodian-doctor's built-in
known-audit-key list, producing a spurious "unknown audit key" warning
under --strict. Declared it via
plugin_audit_keys(the documentedescape hatch); the key stays active, no check is disabled.
Verified locally (Python 3.11): uv sync, ruff check src test,
pytest (347 passed), check_docs.sh, and custodian-doctor --strict all pass.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com