fix(ci): resolve E701 lint findings in watcher_status_pane#66
Merged
Conversation
Expand 11 single-line `if/elif X: stmt` compound statements into proper multi-line blocks in the worker-backend / executor-lane render helpers. These E701 (multiple statements on one line) violations were the sole remaining custodian-audit findings, surfaced via the ruff adapter, and caused `custodian-multi --fail-on-findings` to exit non-zero on main. No behavior change — pure formatting. Audit now clean (0 findings) and `custodian-doctor --strict` passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…strict The deployed Custodian reconcile detector consumes audit.reconcile_enforce, but the released doctor's --strict typo-guard allow-list does not yet list the key, so it emits "unknown audit key 'reconcile_enforce'" and exits 1 — turning the CI "Custodian doctor" job red on main. Declare reconcile_enforce via the supported audit.plugin_audit_keys escape hatch so the typo-guard accepts it while R1/R2 enforcement stays fully active. Removable once the released doctor adds the key to its known set. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…se positive)
The custodian-audit job's lone remaining MED finding was P3:
[queue] reader '../OperationsCenter/.../intake/main.py' not found
— cannot verify path_fragment '.console/queue' on reader side
P3 (path coverage) resolves reader_path unconditionally and emits a finding
when it cannot be found. The reader lives in a SIBLING repo that is never
checked out in OperatorConsole's single-repo CI, so any reader_path here is a
structurally guaranteed false positive on CI (it only passed locally because a
sibling clone happened to exist). P2 already silently skips a missing reader;
P3 does not, which is why it was the sole failure.
Declare only the writer side. P1 (writer keys) and P3 writer-side path
coverage still fully audit our half of the contract; the cross-repo reader
half belongs to the multi-repo fleet audit where both repos coexist.
Also revert the temporary `-v` diagnostic flag on the audit invocation.
Verified in an isolated single-repo checkout (no siblings, CI-matching
ruff/vulture/ty): custodian-multi --fail-on-findings and
custodian-doctor --strict both exit 0, audit reports 0 findings.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand 11 single-line
if/elif X: stmtcompound statements into propermulti-line blocks in the worker-backend / executor-lane render helpers.
These E701 (multiple statements on one line) violations were the sole
remaining custodian-audit findings, surfaced via the ruff adapter, and
caused
custodian-multi --fail-on-findingsto exit non-zero on main.No behavior change — pure formatting. Audit now clean (0 findings) and
custodian-doctor --strictpasses.Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com