fix(ci): green main — register reconcile_enforce key + drop unused import#242
Merged
Conversation
…port Two pre-existing CI failures on main: - Custodian doctor (--strict): the audit key `reconcile_enforce` (added in #238) was never registered in `plugin_audit_keys`, so doctor flagged it as an "unknown audit key (typo?)" and --strict turned the warning into a non-zero exit. It is a legitimate OC plugin config flag — add it to plugin_audit_keys (matching the existing oc1_exempt/oc7_exempt/known_values registrations). - Lint (ruff): `unittest.mock.call` was imported but unused in tests/test_check_signal_collector.py (F401). Removed via `ruff check --fix`; `call` is not referenced elsewhere in the file. Verified locally with the repo's .venv: ruff check . -> All checks passed! custodian-doctor --strict --repo . -> OK pytest tests/test_check_signal_collector.py -> 16 passed Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two pre-existing CI failures on main:
Custodian doctor (--strict): the audit key
reconcile_enforce(added in feat(reconcile): reconcile OperationsCenter .console (prune + scrub + enforce) #238) was never registered in
plugin_audit_keys, sodoctor flagged it as an "unknown audit key (typo?)" and --strict
turned the warning into a non-zero exit. It is a legitimate
OC plugin config flag — add it to plugin_audit_keys (matching the
existing oc1_exempt/oc7_exempt/known_values registrations).
Lint (ruff):
unittest.mock.callwas imported but unused intests/test_check_signal_collector.py (F401). Removed via
ruff check --fix;callis not referenced elsewhere in the file.Verified locally with the repo's .venv:
ruff check . -> All checks passed!
custodian-doctor --strict --repo . -> OK
pytest tests/test_check_signal_collector.py -> 16 passed
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com