🚑 PlayerMotion.Api.Launch の定義範囲を修正#2261
Merged
Merged
Conversation
[regenerate cache]
haiiro2gou
force-pushed
the
fix/player_motion_objective
branch
from
51d4208 to
6feb267
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the declaration scope metadata for the PlayerMotion.Api.Launch scoreboard objective so it can be referenced from the intended external entry points (notably the lib:motion/core/*/player wrappers), aligning the objective’s “visibility” with its actual usage.
Changes:
- Replace
# @internalonPlayerMotion.Api.Launchobjective declaration with an explicit# @within functionallowlist. - Allow usage from
player_motion:**,lib:motion/core/looking/player, andlib:motion/core/xyz/player.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ChenCMD
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.