✨ [Artifact 1361] ユニコーンのツノを作成#1890
Open
Lapis-LJA wants to merge 13 commits into
Open
Conversation
haiiro2gou
reviewed
May 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new artifact #1361「ユニコーンのツノ」 to the datapack’s artifact system, including registration, item generation, and an onAttack trigger that deals random-element magic damage while bypassing the target’s resist behavior.
Changes:
- Register artifact 1361 into the artifact registry pool and give/attack trigger function tags.
- Add give definition (name/lore/MP cost/cooldown/attack info) for artifact 1361.
- Implement onAttack trigger flow: condition check (min damage threshold, non-DoT, victim existence) → random victim selection → VFX + damage application with randomized element.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Asset/data/asset/tags/functions/artifact/register.json | Adds artifact 1361 registration function to the global register tag. |
| Asset/data/asset/tags/functions/artifact/give.json | Adds artifact 1361 give trigger to the global give tag. |
| Asset/data/asset/tags/functions/artifact/attack.json | Hooks artifact 1361 trigger into the global on-attack execution list. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/register.mcfunction | Registers artifact ID 1361 into rarity registries. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/give/1.trigger.mcfunction | Dispatches to the give builder when context id is 1361. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/give/2.give.mcfunction | Defines item metadata, usage slot/trigger, costs/cooldowns, and AttackInfo for the artifact. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/trigger/1.trigger.mcfunction | Runs condition checks when the player’s hotbar artifact ID matches 1361. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/trigger/2.check_condition.mcfunction | Ensures base eligibility + non-DoT + victim presence + damage threshold before executing main logic. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/trigger/3.main.mcfunction | Consumes usage resources and selects a random Victim to apply the artifact effect. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/trigger/as_target.mcfunction | Applies VFX, randomizes element type, and performs damage with modifier/bypass setup. |
| Asset/data/asset/functions/artifact/1361.unicorn_horn/trigger/vfx.mcfunction | Visual/audio effect for the artifact activation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # ここから先は神器側の効果の処理を書く | ||
|
|
||
| # check_conditionで判定したTempTargetの中で最も近い対象を攻撃対象とする |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.