Skip to content

Add security note to ExampleContractOfferer #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stackoverflowed1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add security note to ExampleContractOfferer #1380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/SeaportDocumentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,13 @@ contract ExampleContractOfferer is ContractOffererInterface {
}
```

**Security Note:**

This `ExampleContractOfferer` is intentionally simplified and is **not** a secure
reference implementation. Production contract offerers must carefully consider
authorization logic, reentrancy risks, state consistency, and validation of all
external inputs.

Remember to create a [Seaport Improvement Protocol (SIP)](https://github.com/ProjectOpenSea/SIPs) proposal for any novel Seaport app.

## Bulk Order Creation
Expand Down