Fix QuickStart README Instructions#11
Merged
Merged
Conversation
milindsrivastava1997
requested changes
Oct 28, 2025
| Copy the code from [QuickStart.java](flinksketch-examples/src/main/java/dev/projectasap/flinksketch/examples/quickstart/QuickStart.java) to `src/main/java/com/mycompany/app/App.java`. | ||
| Copy the code from [QuickStart.java](flinksketch-examples/src/main/java/dev/projectasap/flinksketch/examples/quickstart/QuickStart.java) to `src/main/java/com/mycompany/app/App.java`, and make these changes: | ||
| - Change the package from `package dev.projectasap.flinksketch.examples.quickstart;` to `package com.mycompany.app;` | ||
| - Rename the class from `public class QuickStart` to `public class App` |
Contributor
There was a problem hiding this comment.
Can we just keep it as QuickStart.java? That way the user has to change one less thing for the quickstart.
| ### 4. Write Your Flink Job | ||
|
|
||
| Copy the code from [QuickStart.java](flinksketch-examples/src/main/java/dev/projectasap/flinksketch/examples/quickstart/QuickStart.java) to `src/main/java/com/mycompany/app/App.java`. | ||
| Copy the code from [QuickStart.java](flinksketch-examples/src/main/java/dev/projectasap/flinksketch/examples/quickstart/QuickStart.java) to `src/main/java/com/mycompany/app/App.java`, and make these changes: |
Contributor
There was a problem hiding this comment.
Explicitly mention the file path of QuickStart.java so the user can easily run a cp command
milindsrivastava1997
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed QuickStart to include changes that need to be made for the job to successfully run.