refactor: eliminate code duplication in precompute engine + bench_precompute_sketch binary#233
Merged
Merged
Conversation
zzylol
force-pushed
the
pr/F-refactor-bench-binary
branch
from
2372141 to
decbcc8
Compare
zzylol
force-pushed
the
pr/E-correctness-tests-comparison
branch
from
8c04bc5 to
47d279e
Compare
zzylol
force-pushed
the
pr/E-correctness-tests-comparison
branch
2 times, most recently
from
443c7e0 to
31906ef
Compare
zzylol
force-pushed
the
pr/F-refactor-bench-binary
branch
from
decbcc8 to
86a5c69
Compare
zzylol
force-pushed
the
pr/F-refactor-bench-binary
branch
from
86a5c69 to
480ae78
Compare
…nary - Refactor Worker to use WorkerRuntimeConfig struct and Arc<AggregationConfig> - Add bench_precompute_sketch binary for precompute engine benchmarking - Add e2e_precompute_equivalence integration test - Expand design doc with second-tier merge worker design Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Define WorkerRuntimeConfig struct and destructure it in Worker::new - Update engine.rs to construct WorkerRuntimeConfig when creating workers - Fix make_worker test helper to use WorkerRuntimeConfig - Fix AggregationConfig::new calls in accumulator_factory tests (17-arg) - Fix .inner.sketch.get_n() → .inner.count() in e2e test Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…nary - Add missing 17th arg (value_column: None) to AggregationConfig::new in bench_precompute_sketch.rs and e2e_precompute_equivalence.rs - Add bench_precompute_sketch.rs stub to Dockerfile dependency cache layer Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zzylol
force-pushed
the
pr/F-refactor-bench-binary
branch
from
1c8c533 to
14ceb05
Compare
milindsrivastava1997
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench_precompute_sketchbinary for standalone precompute engine benchmarkinge2e_precompute_equivalenceintests/This is PR F of 6 stacked PRs splitting #162
Stacking order:
Test plan
cargo build --bin bench_precompute_sketchsucceedscargo testintegration test intests/e2e_precompute_equivalence.rspasses🤖 Generated with Claude Code