Skip to content

Remove deprecated curl_close #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colemanw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove deprecated curl_close #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CRM/Bic/Parser/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
$option_group = civicrm_api3('OptionGroup', 'getsingle', ['name' => 'bank_list']);
$option_group_id = (int) $option_group['id'];
}
catch (Exception $e) {

Check failure on line 123 in CRM/Bic/Parser/Parser.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-lowest 

In method "CRM_Bic_Parser_Parser::updateEntries", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 123 in CRM/Bic/Parser/Parser.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.1 prefer-lowest 

In method "CRM_Bic_Parser_Parser::updateEntries", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.

Check failure on line 123 in CRM/Bic/Parser/Parser.php

View workflow job for this annotation

GitHub Actions / PHPStan with PHP 8.4 prefer-stable 

In method "CRM_Bic_Parser_Parser::updateEntries", caught "Exception" must be rethrown. Either catch a more specific exception, add a "throw" clause in the "catch" block to propagate the exception or add a "// @IgnoreException" comment.
return $this->createError('OptionGroup not found. Reinstall extension!');
}

Expand Down Expand Up @@ -232,7 +232,6 @@
$data = curl_exec($ch);

$curl_errno = curl_errno($ch);
curl_close($ch);

if (!$curl_errno) {
return $data;
Expand Down
Loading