chore : signup and login intergrations with backend#38
Open
chore : signup and login intergrations with backend#38
Conversation
isuruK2003
requested changes
Mar 22, 2025
Member
isuruK2003
left a comment
isuruK2003
left a comment
There was a problem hiding this comment.
Issues in the app.settings.ts file
|
|
||
| const PORTS = { | ||
| production: 8000, | ||
| production: 8081, |
|
|
||
| export const settings: Settings = { | ||
| export const settings = { | ||
| rebotWebsocket: { |
Member
There was a problem hiding this comment.
interfaces should not be removed, since this is typescript file
Comment on lines
-1
to
-9
| /** | ||
| * App Configuration | ||
| * ----------------- | ||
| * This file contains all development-level app configurations. | ||
| * Not to be confused with user-configurable app settings like theme preferences. | ||
| * | ||
| * Note: | ||
| * To connect to a local backend instead of production: Set isProduction to false | ||
| */ |
| export const settings = { | ||
| rebotWebsocket: { | ||
| isUserVisible: false, | ||
| value: `ws://${BACKEND_URL}/ws/rebot` |
Member
There was a problem hiding this comment.
line 15 change affects line 20. So change it to ws://${BACKEND_DOMAIN}:${BACKEND_PORT}/ws/rebot
Comment on lines
+29
to
+33
| login: "/login", | ||
| signupStepOne: "/signup/step-one", | ||
| signupStepTwo: "/signup/step-two", | ||
| forgotPassword: "/forget-password/", | ||
| resetPassword: "/reset-password" |
Member
There was a problem hiding this comment.
need to be prefixed with the port and backend url. Like login: '${BACKEND_URL}/login'
Member
|
I tested login but its not working this time its the url is wrong, because of the issues in settings file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@isuruK2003 check from your side