3d ddpm #1874
Merged
3d ddpm #1874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
20 tasks
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
virginiafdez
reviewed
Nov 7, 2024
virginiafdez
reviewed
Nov 7, 2024
Contributor
virginiafdez
left a comment
virginiafdez
left a comment
There was a problem hiding this comment.
This looks fine by me. Maybe it is good to remove the torch.load warning in the inference section, but besides this, it all looks fine.
KumoLiu
reviewed
Nov 8, 2024
KumoLiu
approved these changes
Nov 8, 2024
Contributor
KumoLiu
left a comment
KumoLiu
left a comment
There was a problem hiding this comment.
Thanks for the PR! Overall looks good to me. Several minor comments.
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address some of #1769.
Description
This adds the missing 3d DDPM tutorial which now functions.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>