feat: add support for biren device

[DSFans2014]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[hami-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DSFans2014
Once this PR has been reviewed and has the lgtm label, please assign shouren for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the HAMi project's device compatibility by introducing full support for Biren devices. The changes encompass the necessary code for device management, updates to the deployment configurations via Helm, and integration into the core scheduling logic. This enhancement allows users to leverage Biren hardware within their Kubernetes environments managed by HAMi.

Highlights

• Biren Device Support: Added comprehensive support for Biren devices, including device-specific logic, resource handling, and configuration.
• Helm Chart Updates: Modified Helm charts to include Biren device parameters and resource definitions, enabling proper deployment and recognition within the Kubernetes cluster.
• Scheduler Integration: Integrated Biren devices into the scheduler's configuration, allowing the scheduler to recognize, manage, and allocate Biren resources.
• Unit Tests: Introduced a dedicated test file for Biren device logic, ensuring the new functionality is robust and reliable.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for Biren devices into the HAMi scheduler. The changes include updating Helm chart configurations for Biren resources, implementing the device.Devices interface for Biren devices in pkg/device/biren/device.go, and integrating the new device type into the scheduler's configuration and testing. The review identified several critical issues, including a Go syntax error in a loop, an undefined variable dieMode, and an incorrect calculation of allocated devices. Additionally, multiple test failures were noted due to incorrect initialization, devType usage, annotation keys, and resource name mismatches. Suggestions were also made to improve code readability and consistency, such as using == for string comparisons, avoiding variable shadowing, and maintaining consistent receiver names in methods.

[codecov]

Codecov Report

❌ Patch coverage is 91.30435% with 12 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/device/biren/device.go	92.48%	9 Missing and 1 partial ⚠️
pkg/scheduler/config/config.go	60.00%	1 Missing and 1 partial ⚠️

Flag	Coverage Δ
unittests	53.64% <91.30%> (+0.56%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/scheduler/config/config.go	77.88% <60.00%> (-0.29%)	⬇️
pkg/device/biren/device.go	92.48% <92.48%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.