Skip to content

Fix: clean mesh FBX를 pre-rig 모델 기준으로 수정#202

Merged
yyuneu merged 2 commits into
mainfrom
fix/clean-mesh-pre-rig
Jun 4, 2026
Merged

Fix: clean mesh FBX를 pre-rig 모델 기준으로 수정#202
yyuneu merged 2 commits into
mainfrom
fix/clean-mesh-pre-rig

Conversation

@yyuneu

@yyuneu yyuneu commented Jun 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Tripo API가 FBX를 반환할 때 .glb로 저장하던 버그 수정 (Unity "invalid magic" 크래시 원인)
  • clean mesh FBX 생성 시점을 rig 완료 후 → model 완료 후(pre-rig)로 수정 (뼈대 없는 상태에서 변환)
  • image_to_model 태스크에 out_format: "glb" 명시 추가

Tasks

  • FileValidatorvalidateGlb(byte[]) 오버로드 추가
  • TripoApiServiceimage_to_modelout_format: "glb" 추가
  • MascotGenerationService — Phase 1/2 다운로드 후 GLB 매직바이트 검증 (FBX면 Phase 2 rig 실패 처리, Phase 1 변환 skip)
  • stripRig.js — gltf-transform 제거, assimp 변환만 남김
  • clean mesh 생성 시점: rig 완료 → model 완료(pre-rig)로 변경

To Reviewer

  • 운영 DB 즉각 조치 완료: site 1 model_url 유효 GLB로 복구
  • Tripo FBX 반환은 재현 조건 불명확 — out_format: "glb" 명시 + magic byte 검증으로 방어

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yyuneu, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 25 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4f766aed-9eb5-4243-b39b-7a530a558585

📥 Commits

Reviewing files that changed from the base of the PR and between a9e865a and 54bbf32.

📒 Files selected for processing (4)
  • guideon-admin-bff/src/main/java/com/guideon/guideonbackend/domain/mascot/service/MascotGenerationService.java
  • guideon-admin-bff/src/main/java/com/guideon/guideonbackend/domain/mascot/service/TripoApiService.java
  • guideon-admin-bff/src/main/java/com/guideon/guideonbackend/global/storage/FileValidator.java
  • mesh-processor/src/stripRig.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/clean-mesh-pre-rig

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yyuneu yyuneu merged commit fc91775 into main Jun 4, 2026
2 checks passed
@yyuneu yyuneu deleted the fix/clean-mesh-pre-rig branch June 4, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant