Added 'Charts' section for quick visualization of CSV outputs#1
Added 'Charts' section for quick visualization of CSV outputs#1dihydrogenmonoxid-ama wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
@dihydrogenmonoxid-ama
Nice contribution — self-contained, zero-dependency, theme-aware, and consistent with the existing panels. A few things to address before merge:
Must fix
Drag-and-drop into Charts is broken. Help + CHANGELOG say you can drop CSVs into the Charts view, but charts-panel.js only wires the file <input>. The global handler in app.js intercepts the drop first:
const onDocDrop = (e) => { ...; loadFile(e.dataTransfer.files[0]); }; // → geometry loader, first file onlySo a dropped CSV goes to the FDS geometry loader, not chartsPanelHandleFiles. Either implement DnD (gate onDocDrop on the active page and route .csv to charts) or drop the claim from Help/CHANGELOG.
Should fix
- Dual-axis silently merges 3+ units.
getActiveSeriesGroupedputs the first unit on the left and everything else on the right — so 3 distinct units share one right-hand scale labeled onlyValue (mixed). Misleading for a publication-style export. Warn the user, or refuse the 2nd axis when the right group is itself mixed. - No downsampling.
_devc.csvfiles often have 10⁴–10⁵ rows; every render walks all points. Add a point-stride above ~5000 to keep redraw/resize smooth. - Scope: the PR also adds a
.outlog viewer + Linter button to the Code tab. That's a separate feature from "Charts" — consider splitting or retitling.
Nits
- Version mismatch: CHANGELOG says
charts-panel.js→20260522D, file/index.htmlsay20260522E. - Squash the two identical commits.
- Decimal-comma parse uses
replace(',', '.')(first comma only) —1.234,56becomes1.234.
|
Thank you @dihydrogenmonoxid-ama very interesting expansion! |
|
@dihydrogenmonoxid-ama I was reflecting on this new component. |
a1e228e to
cb2885d
Compare
…warning, downsampling, decimal-comma fix, version unify
|
Thank you @chraibi for the thorough review, and thank you @ProfRino for your encouragement! I have addressed all points in the latest commit:
Please let me know if anything needs further adjustment. Happy to iterate!
|
|
@dihydrogenmonoxid-ama thanks for trying to integrate the comment but please do not rush through the changes. Please make the integration with Otput section more aligned with the other tabs. The Open CSV file(s) should appear on the right column below Soot, Slice, Bouday, Charts This solution current solution in not aligned to the existing naviagation style The current version seem buggy too see the image here Please take the time you need to make a nice integration of this new feature |
|
@dihydrogenmonoxid-ama thanks for the quick reaction time ^^ Three things still open before merge:
Take your time on the integration. No rush and many thanks for your contribution! |



Dear Prof. Lovreglio,
First of all, thank you for your great work on this project! It has been incredibly useful.
I have implemented a new 'Charts' section to allow for a quick overview of automatically generated FDS simulation CSV files.
Key features of this update:
I hope this contributes positively to the project. Any feedback or suggestions regarding this contribution would be greatly appreciated.
Best regards,
dihydrogenmonoxid