Skip to content

fix(home): restore poster and catalog skeletons with correct TV/mobile title visibility#433

Merged
ProdigyV21 merged 5 commits into
ProdigyV21:mainfrom
Himanth-reddy:fix/restore-poster-skeletons
Jul 4, 2026
Merged

fix(home): restore poster and catalog skeletons with correct TV/mobile title visibility#433
ProdigyV21 merged 5 commits into
ProdigyV21:mainfrom
Himanth-reddy:fix/restore-poster-skeletons

Conversation

@Himanth-reddy

Copy link
Copy Markdown
Collaborator

Restores clean dynamic poster and catalog skeletons in the home feed. Reverts data-layer workarounds and implements conditional title rendering for TV poster lists where card titles are disabled.

@ProdigyV21

Copy link
Copy Markdown
Owner

The PR removes the Smooth Scrolling row/action, but tvGeneralRowsForSection("appearance") still includes row id 36. On TV/D-pad this can create an invisible/unhandled focus stop in Appearance settings.

Please either:

  1. fully keep Smooth Scrolling: restore the row, Enter action, and make Home respect smoothScrolling; or
  2. fully remove it: remove row 36 from tvGeneralRowsForSection, remove the unused callback/state plumbing from SettingsScreen, and make the PR description clear that Smooth Scrolling is being removed.

After that, I think this is okay.

@ProdigyV21

Copy link
Copy Markdown
Owner

Why does smooth scrolling need to be removed?

@Himanth-reddy

Copy link
Copy Markdown
Collaborator Author

I originally mistakenly thought that the "Smooth Scrolling" toggle was doing nothing because even with the toggle turned off, the list still scrolled smoothly. But after checking it was working so i reverted the commits related to smooth scrolling

@Himanth-reddy

Copy link
Copy Markdown
Collaborator Author

Sorry for making you confused

@ProdigyV21 ProdigyV21 merged commit bfb3997 into ProdigyV21:main Jul 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants