fix: harden settings screen values against NullPointerException (#413)#425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #413 where opening the Settings screen consistently crashes with a
NullPointerException: Attempt to invoke interface method 'int java.lang.CharSequence.length()' on a null object reference.Root Cause
When opening the Settings screen or switching locales (such as
es-ES), setting strings or preference values loaded fromDataStore/SharedPreferencesor resource lookups can passnullinto UI row composables and formatters.Previously, functions such as
SettingsRow,MobileSettingsRow,localizeSettingValue, andformatUserAgentPreviewexpected non-nullStringparameters and invoked operations like.isNotBlank(),.isNotEmpty(), or.ifBlank {}on them directly, causingCharSequence.length()to be called on a null reference.Changes Made
SettingsRows.kt:localizeSettingValue(value: String?)andSettingsRow(..., value: String?)to safely handle nullable string inputs, defaulting to empty strings before evaluating length/emptiness.SettingsScreen.kt:formatUserAgentPreview(value: String?, maxLength: Int)andMobileSettingsRow(..., value: String?)to accept nullable values and evaluate safe fallback strings via.orEmpty().Resolves #413.