Skip to content

feat: extend accent colour to profile selection screen focus borders#417

Open
EierKopZA wants to merge 1 commit into
ProdigyV21:mainfrom
EierKopZA:feat/profile-selection-accent-border
Open

feat: extend accent colour to profile selection screen focus borders#417
EierKopZA wants to merge 1 commit into
ProdigyV21:mainfrom
EierKopZA:feat/profile-selection-accent-border

Conversation

@EierKopZA

Copy link
Copy Markdown
Contributor

feat: Extend accent colour to profile selection screen focus borders

Overview

Replaces hardcoded Color.White focus borders with the user's selected accent colour across all four TV-composable elements on the profile selection screen. Previously the accent colour setting was ignored on this screen despite being respected everywhere else (settings, player chrome, details, search, etc.).

Changes

File: app/src/main/kotlin/com/arflix/tv/ui/screens/profile/ProfileSelectionScreen.kt

Added resolveAccentColor(fallback = Color.White) to each composable and replaced the hardcoded Color.White in the focusedBorder parameter:

Composable Before After
ProfileAvatar Color.White 3dp focus ring accentColor 3dp focus ring
AddProfileButton Color.White 3dp focus ring accentColor 3dp focus ring
ManageProfilesButton Color.White 2dp focus ring accentColor 2dp focus ring
CloudConnectButton Color.White.copy(alpha=0.6f) 2dp focus ring accentColor.copy(alpha=0.6f) 2dp focus ring

This means D-pad navigation focus rings on the profile picker now respond to the user's Settings → General → Accent Color selection, providing a consistent themed experience across the entire app.

Testing

  1. Open Settings → General → Accent Color and select a non-white colour (e.g. Red, Blue, Gold)
  2. Navigate to the profile selection screen (switch profile)
  3. D-pad through each profile avatar — verify the focus ring matches the selected accent colour
  4. Focus the Add Profile button — verify the ring uses the accent colour
  5. Focus the Manage Profiles / Done button — verify the ring uses the accent colour
  6. Focus the Connect to Cloud button — verify the ring uses the accent colour
  7. Reset accent colour to White — verify all rings return to white as expected

Copilot AI review requested due to automatic review settings June 28, 2026 10:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the app’s accent color theming to the TV profile selection screen by replacing hardcoded white focus borders with the currently selected accent color, aligning this screen’s D-pad focus visuals with the rest of the app’s theming.

Changes:

  • Added resolveAccentColor(fallback = Color.White) to ProfileAvatar, AddProfileButton, ManageProfilesButton, and CloudConnectButton.
  • Updated each composable’s focusedBorder BorderStroke color from Color.White (or Color.White.copy(alpha = …)) to the resolved accent color (preserving the existing alpha usage where applicable).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants