Skip to content

fix: improve accessibility for interactive elements #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Priyanshu-byte-coder merged 1 commit into from
May 30, 2026
Merged

fix: improve accessibility for interactive elements #1562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/components/AccountToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export default function AccountToggle() {
<button
key={`${option.label}-${option.value ?? "primary"}`}
type="button"
aria-pressed={isActive}
onClick={() => setSelectedAccount(option.value)}
className={`rounded-lg border px-3 py-2 text-sm font-medium transition-colors ${
isActive
Expand Down
9 changes: 6 additions & 3 deletions src/components/SignOutButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export default function SignOutButton() {
<button
type="button"
onClick={handleSignOut}
aria-label="Confirm sign out"
disabled={signingOut}
className="inline-flex h-10 items-center rounded-full bg-red-600 px-4 text-sm font-semibold text-white hover:bg-red-700 disabled:opacity-70"
>
Expand All @@ -35,6 +36,7 @@ export default function SignOutButton() {
onClick={() => setConfirming(false)}
disabled={signingOut}
className="inline-flex h-10 items-center rounded-full border px-4 text-sm font-semibold hover:bg-gray-100"
aria-label="Cancel sign out"
>
Cancel
</button>
Expand All @@ -48,6 +50,7 @@ export default function SignOutButton() {
disabled={signingOut}
suppressHydrationWarning
onClick={() => setConfirming(true)}
aria-label="Sign out"
className="inline-flex h-10 items-center gap-2 rounded-full border border-[var(--destructive)]/50 bg-[var(--destructive)]/80 px-4 text-sm font-semibold text-[var(--destructive-foreground)] transition-colors hover:bg-[var(--destructive)] disabled:cursor-not-allowed disabled:opacity-70"
>
{signingOut && (
Expand All @@ -69,8 +72,8 @@ export default function SignOutButton() {
<path
className="opacity-75"
fill="currentColor"
d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2
5.291A7.962 7.962 0 014 12H0c0
d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4zm2
5.291A7.962 7.962 0 014 12H0c0
3.042 1.135 5.824 3 7.938l3-2.647z"
/>
</svg>
Expand All @@ -79,4 +82,4 @@ export default function SignOutButton() {
Sign out
</button>
)
}
}
1 change: 1 addition & 0 deletions src/components/UserAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ export default function UserAvatar() {
return (
<a
href={session?.githubLogin ? `https://github.com/${session.githubLogin}` : "#"}
aria-label={`Open GitHub profile for ${name}`}
target="_blank"
rel="noopener noreferrer"
tabIndex={0}
Expand Down
Loading