Skip to content

Fix unit test suite crash (missing jsdom) and resolve failing tests#1535

Open
ArshVermaGit wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main
Open

Fix unit test suite crash (missing jsdom) and resolve failing tests#1535
ArshVermaGit wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
ArshVermaGit:main

Conversation

@ArshVermaGit
Copy link
Copy Markdown

Description

This PR resolves a critical infrastructure issue where the local unit testing suite was failing to start, and patches 4 brittle tests that were failing once the suite booted up.

Resolved Issue

Resolves #1534

Fixes:

  • 🐛 Missing Dependency: Installed jsdom as a devDependency to prevent Vitest from throwing a missing environment error on startup.
  • 🐛 API Test Assertions: Updated the expected payload in test/user-settings-api.test.ts to include the newly added bio: "" field, properly aligning the mock expectations with the API response.
  • 🐛 DOM Selector Ambiguity: Refactored the DOM query in test/components/DashboardHeader.test.tsx from getByText(/Dashboard/i) to getByRole("heading", { name: "Dashboard" }) because the test was accidentally matching the "Dashboard overview" subtitle text.

How to Verify

  1. Pull down this branch.
  2. Run npm install to grab jsdom.
  3. Run npm run test.
  4. Verify that all 606 unit tests pass with a 100% success rate.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@ArshVermaGit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts) labels May 29, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR on DevTrack! 🎉

A maintainer will review it within 48 hours. While you wait:

  • Make sure CI is passing (type-check + lint)
  • Double-check the PR description is filled out and the issue is linked
  • Feel free to ask questions in Discussions if you need help

If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!

Copy link
Copy Markdown
Author

@ArshVermaGit ArshVermaGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Priyanshu-byte-coder ! Issue #1534 has been resolved. Please review the PR and merge it under GSSoC. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:design GSSoC type bonus: UI/design (+10 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Unit Test Suite Fails Immediately Due to Missing jsdom Dependency

1 participant