Skip to content

feat(auth): improve GitHub sign-in failure feedback with clear inline guidance (fixes #1529)#1533

Open
ishwarc04 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
ishwarc04:feat/1529-auth-error-feedback
Open

feat(auth): improve GitHub sign-in failure feedback with clear inline guidance (fixes #1529)#1533
ishwarc04 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
ishwarc04:feat/1529-auth-error-feedback

Conversation

@ishwarc04
Copy link
Copy Markdown

Linked Issue

Fixes #1529

Problem

When GitHub authentication failed, users were redirected to the sign-in page without a clear explanation.
This made local setup and OAuth troubleshooting confusing.

What I changed

  • Added a dedicated auth error utility to normalize and map auth error codes to user-friendly messages.
  • Improved the sign-in page error banner content for GitHub auth failures.
  • Added practical next-step guidance in the UI (OAuth credentials and callback URL checks).
  • Preserved stale-error cleanup in the URL while keeping banner display behavior reliable.
  • Added focused unit tests for auth error normalization and fallback mapping.
  • Added a contributor summary file for issue tracking and review context.

Files changed

  • src/lib/auth-error-message.ts
  • src/app/auth/signin/page.tsx
  • test/auth-error-message.test.ts
  • ISSUE_1529_SUMMARY.md

Validation

  • Ran app locally with development server.
  • Ran focused tests for new logic:
    • npm run test -- auth-error-message.test.ts
  • Test coverage added for:
    • empty and malformed auth error input
    • URL-decoded error handling
    • known and unknown error-code mapping

Impact

  • Better user experience during GitHub auth failures.
  • Faster troubleshooting for contributors during local OAuth setup.
  • Clearer and actionable feedback instead of silent redirect confusion.

Notes

  • jsdom was added to devDependencies to support test environment requirements during Vitest execution.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

@ishwarc04 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:design GSSoC type bonus: UI/design (+10 pts) type:docs GSSoC type bonus: documentation (+5 pts) type:feature GSSoC type bonus: new feature type:security GSSoC type bonus: security (+20 pts) type:testing GSSoC type bonus: tests (+10 pts) labels May 29, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR on DevTrack! 🎉

A maintainer will review it within 48 hours. While you wait:

  • Make sure CI is passing (type-check + lint)
  • Double-check the PR description is filled out and the issue is linked
  • Feel free to ask questions in Discussions if you need help

If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:design GSSoC type bonus: UI/design (+10 pts) type:docs GSSoC type bonus: documentation (+5 pts) type:feature GSSoC type bonus: new feature type:security GSSoC type bonus: security (+20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] Improve error feedback when GitHub authentication fails

1 participant