refactor: remove hardcoded data window strings in dashboard components#1405
Closed
Sarthak-Nayak wants to merge 7 commits into
Closed
refactor: remove hardcoded data window strings in dashboard components#1405Sarthak-Nayak wants to merge 7 commits into
Sarthak-Nayak wants to merge 7 commits into
Conversation
|
@Sarthak-Nayak is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactored multiple dashboard metrics components to eliminate hardcoded date window text strings (e.g., "Last 90d", "Last 30d"). These UI labels are now dynamically generated using array mapping and template literals derived directly from their respective tracking constants and state variables. This ensures the UI remains synced and robust against future date window configuration changes.
Changes Made
CommitTimeChart.tsx,ActivityRingChart.tsx, and other dashboard cards to dynamically map over day values.page.tsxto utilize a unified data window constant for public metrics visibility.Closes
Closes #956