Skip to content

Fix text contrast landing page #1213#1354

Closed
shankumar7 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
shankumar7:fix-text-contrast-landing-page
Closed

Fix text contrast landing page #1213#1354
shankumar7 wants to merge 3 commits into
Priyanshu-byte-coder:mainfrom
shankumar7:fix-text-contrast-landing-page

Conversation

@shankumar7
Copy link
Copy Markdown
Contributor

@shankumar7 shankumar7 commented May 28, 2026

Summary

This PR addresses several UI and performance issues on the landing page, primarily focusing on improving text contrast for accessibility, fixing severe layout lag, and unifying the footers.

Closes #1213

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / code cleanup

Changes Made

  • Accessibility: Replaced low-contrast hardcoded hex values (#222, #333, #444, #555) across the landing page and globals.css with a highly readable grey (#9ca3af).
  • Performance: Fixed a severe layout thrashing/lag issue caused by the MouseSpotlight component. It now correctly uses GPU-accelerated translate3d transforms instead of modifying left/top CSS properties on every mouse movement.
  • Scroll Fix: Added overscroll-behavior: none; to the global html and body tags to prevent the Mac rubber-banding effect from exposing the background behind the footer.
  • Footer Clean-up: Removed a redundant, overlapping LandingFooter component and integrated its essential links (like the MIT License) into a unified, beautified global Footer.
  • UI Overflow Fix: Increased the maxWidth of the Sign-In page container to comfortably fit the large "WELCOME BACK" display text.

How to Test

Steps for the reviewer to verify this works:

  1. Spin up the dev server and visit the landing page and verify that small text, subheadings, and secondary buttons now have much better contrast.
  2. Move your mouse rapidly around the landing page and sign-in page; the blue cursor spotlight should feel buttery smooth with no frame drops.
  3. On a Mac trackpad, attempt to scroll past the top and bottom of the page (overscroll); the page should no longer bounce and expose the root background.
  4. Check the bottom of the page to verify there is only one unified, responsive footer.

Checklist

  • Linked issue in summary
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Self-reviewed the diff
  • Added/updated tests if applicable

@vercel
Copy link
Copy Markdown

vercel Bot commented May 28, 2026

@shankumar7 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels May 28, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR on DevTrack! 🎉

A maintainer will review it within 48 hours. While you wait:

  • Make sure CI is passing (type-check + lint)
  • Double-check the PR description is filled out and the issue is linked
  • Feel free to ask questions in Discussions if you need help

If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!

@shankumar7
Copy link
Copy Markdown
Contributor Author

@Priyanshu-byte-coder could you please add gssoc:approved label? Thank you!

@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Thanks @shankumar7! We just merged #1355 which covers the MUTED color improvement and some of the same LandingPage.tsx areas. Your PR has some unique improvements worth keeping:

  • MouseSpotlight using transform3d instead of left/top (performance improvement ✓)
  • overscroll-behavior: none in globals.css
  • Footer.tsx changes
  • auth/signin/page.tsx improvements

Please rebase your branch onto main (which now has #1355 merged) and resolve conflicts in LandingPage.tsx and globals.css. After rebasing, we can review and merge the remaining unique changes!

@shankumar7 shankumar7 force-pushed the fix-text-contrast-landing-page branch from ad64eec to 9b11364 Compare May 28, 2026 08:54
@shankumar7
Copy link
Copy Markdown
Contributor Author

hello @Priyanshu-byte-coder, I have rebased the branch onto main and resolved the conflicts as requested! The unique changes (MouseSpotlight transform3d, overscroll-behavior: none, and the Footer.tsx updates) have all been preserved. Let me know if you need any further changes before merging!

@shankumar7 shankumar7 force-pushed the fix-text-contrast-landing-page branch from e765a6f to e74cd40 Compare May 28, 2026 09:03
Priyanshu-byte-coder added a commit that referenced this pull request May 28, 2026
Co-authored-by: shankumar7 <shankumar7@users.noreply.github.com>
@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

Merged manually (squash) — commit b81ba53 in main. Improvements to text contrast and landing page styling included. Thanks @shankumar7!

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:bug GSSoC type bonus: bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve low text contrast across the landing page

2 participants