Skip to content

fix: improve AccountToggle active tab visibility in light mode#1222

Closed
MaitrayeeK wants to merge 34 commits into
Priyanshu-byte-coder:mainfrom
MaitrayeeK:fix/tab-active-indicator
Closed

fix: improve AccountToggle active tab visibility in light mode#1222
MaitrayeeK wants to merge 34 commits into
Priyanshu-byte-coder:mainfrom
MaitrayeeK:fix/tab-active-indicator

Conversation

@MaitrayeeK
Copy link
Copy Markdown
Contributor

Summary

Fixes the AccountToggle component where the active tab indicator was nearly invisible in light mode due to insufficient contrast between the active and inactive tab states.

Closes #1037

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor / code cleanup

Changes Made

  • Wrapped inactive tabs using [var(--card-muted)] and [var(--muted-foreground)] as a consistent reference surface

How to Test

Steps for the reviewer to verify this works:

  1. Switch the app to light mode
  2. Navigate to the dashboard header and locate the account switcher (Personal / Organization / Combined)
  3. Click each tab and verify the active tab

Screenshots (if UI change)

image

Checklist

  • Linked issue in summary
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Self-reviewed the diff
  • Added/updated tests if applicable

@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

@MaitrayeeK is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix labels May 26, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

seffhunnn and others added 21 commits May 27, 2026 12:51
…te-coder#1116)

* fix: persist unread notification count across refreshes

* fix(ci): fix playwright execution runner version mismatch in workflows
* fix: improve sign out button theme contrast

* test: fix failing playwright smoke tests

* fix(ci): fix playwright execution runner version mismatch
* added repo list new UI

* e2e fix

* fix: resolve FriendComparison duplicate import
…er#1135)

* feat: add back to dashboard link on settings page

* fix: resolve merge issues
* fix: add loading spinner and disable refresh button

* fix: improve loading spinner in refresh button
…byte-coder#1169)

* test: add unit tests for scoreAvgPrOpenTimeHours function

* fix: remove duplicate font import in page.tsx

* fix: add missing imports to KeyboardShortcuts.tsx

* fix: move use client directive to top of files

* test: mock new widgets and stream in E2E, fix auth unit tests

* fix: remove duplicate SectionHeader imports

* ci: fix playwright runner invocation to avoid double-version conflict
…get (Priyanshu-byte-coder#1218)

* fix(ai-mentor): resolve React hydration mismatch in date formatting

- Add mounted state to track client-side hydration
- Only call toLocaleDateString after component hydrates
- Prevents timezone/locale mismatches between server and client

* Fix hydration mismatch caused by toLocaleDateString
…yanshu-byte-coder#1232)

* Fix GoalTracker progress overflow issue

* Improve progress bar width clamping

* Fix undefined language badge for repos without detected language
…and dynamic color shift (Priyanshu-byte-coder#1179)

Co-authored-by: Shweta <gdgshweta@gmail.com>
…riyanshu-byte-coder#1227)

* fix(theme): fix theme toggle icon flicker using useSafeLayoutEffect

* fix(ci): fix playwright execution runner version mismatch in workflows
Co-authored-by: yash gupta <you@example.com>
…ing (Priyanshu-byte-coder#1189)

* fix: remove private repository scope from github oauth

* fix: resolve auth heading alignment and footer dark theme
* feat: complete WakaTime integration

* chore: trigger CI

* fix: address Copilot AI review feedback
@Priyanshu-byte-coder
Copy link
Copy Markdown
Owner

CI is failing on this PR. Please fix the failing checks before this can be merged.

Squash merge of Priyanshu-byte-coder#1141 left unresolved conflict markers in package.json,
causing invalid JSON and breaking all Vercel builds since that commit.
Priyanshu-byte-coder and others added 11 commits May 27, 2026 13:53
…nflicts

- Remove duplicate formatActivity import in activity/route.ts (PR#1220 added
  an import at line 1 while the original already had one at line 21)
- Add explicit vitest imports to activity-formatter.test.ts (describe/it/expect)
- Resolve three merge conflict markers in package-lock.json left by PR#1141
  squash merge (lucide-react version and libc field conflicts)
Hobby plan blocks sub-daily crons. Changed 0 * * * * (hourly) to
0 0 * * * (midnight daily) to match Vercel Hobby plan limits.
- Add .github/FUNDING.yml to show Sponsor button on repo
- Add sponsor badge, link, and tier table to README
- Add .vercel and .env* entries to .gitignore

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added type:devops GSSoC type bonus: devops (+15 pts) type:docs GSSoC type bonus: documentation (+5 pts) type:testing GSSoC type bonus: tests (+10 pts) labels May 28, 2026
@MaitrayeeK
Copy link
Copy Markdown
Contributor Author

@Priyanshu-byte-coder Updated the branch. Kindly review it once, it can be merged now.

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MaitrayeeK! The PR title says 'fix: improve AccountToggle active tab visibility' but the diff includes 50+ files — new API routes, SQL migrations, new components, e2e tests, CI workflow changes, and more. This is too large to review as a single PR and carries significant risk of breaking things.

Please split this into separate focused PRs:

  1. The AccountToggle tab visibility fix (CSS tweak in AccountToggle.tsx) — this is the actual fix stated in the title
  2. Any new features (repo analytics, wakatime sync, etc.) as separate PRs

The SQL migration file is especially risky in a bundled PR.

Thanks for understanding!

@MaitrayeeK
Copy link
Copy Markdown
Contributor Author

That happened because I merged the main branch into this branch. Closing this one and will raise another PR with only my issue-related changes.

Thanks.

@MaitrayeeK MaitrayeeK closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:bug GSSoC type bonus: bug fix type:devops GSSoC type bonus: devops (+15 pts) type:docs GSSoC type bonus: documentation (+5 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: AccountToggle tab underline not visible in light mode