fix: improve AccountToggle active tab visibility in light mode#1222
fix: improve AccountToggle active tab visibility in light mode#1222MaitrayeeK wants to merge 34 commits into
Conversation
|
@MaitrayeeK is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
…te-coder#1116) * fix: persist unread notification count across refreshes * fix(ci): fix playwright execution runner version mismatch in workflows
* fix: improve sign out button theme contrast * test: fix failing playwright smoke tests * fix(ci): fix playwright execution runner version mismatch
* added repo list new UI * e2e fix * fix: resolve FriendComparison duplicate import
…er#1135) * feat: add back to dashboard link on settings page * fix: resolve merge issues
* fix: add loading spinner and disable refresh button * fix: improve loading spinner in refresh button
…byte-coder#1169) * test: add unit tests for scoreAvgPrOpenTimeHours function * fix: remove duplicate font import in page.tsx * fix: add missing imports to KeyboardShortcuts.tsx * fix: move use client directive to top of files * test: mock new widgets and stream in E2E, fix auth unit tests * fix: remove duplicate SectionHeader imports * ci: fix playwright runner invocation to avoid double-version conflict
…get (Priyanshu-byte-coder#1218) * fix(ai-mentor): resolve React hydration mismatch in date formatting - Add mounted state to track client-side hydration - Only call toLocaleDateString after component hydrates - Prevents timezone/locale mismatches between server and client * Fix hydration mismatch caused by toLocaleDateString
…der#1196) Co-authored-by: SANCHI GOYAL <sanchigoyal@Mac.lan>
…yanshu-byte-coder#1232) * Fix GoalTracker progress overflow issue * Improve progress bar width clamping * Fix undefined language badge for repos without detected language
…r#1200) Co-authored-by: SANCHI GOYAL <sanchigoyal@Mac.lan>
…and dynamic color shift (Priyanshu-byte-coder#1179) Co-authored-by: Shweta <gdgshweta@gmail.com>
…riyanshu-byte-coder#1227) * fix(theme): fix theme toggle icon flicker using useSafeLayoutEffect * fix(ci): fix playwright execution runner version mismatch in workflows
Co-authored-by: yash gupta <you@example.com>
…ing (Priyanshu-byte-coder#1189) * fix: remove private repository scope from github oauth * fix: resolve auth heading alignment and footer dark theme
* feat: complete WakaTime integration * chore: trigger CI * fix: address Copilot AI review feedback
|
CI is failing on this PR. Please fix the failing checks before this can be merged. |
Squash merge of Priyanshu-byte-coder#1141 left unresolved conflict markers in package.json, causing invalid JSON and breaking all Vercel builds since that commit.
…nflicts - Remove duplicate formatActivity import in activity/route.ts (PR#1220 added an import at line 1 while the original already had one at line 21) - Add explicit vitest imports to activity-formatter.test.ts (describe/it/expect) - Resolve three merge conflict markers in package-lock.json left by PR#1141 squash merge (lucide-react version and libc field conflicts)
Hobby plan blocks sub-daily crons. Changed 0 * * * * (hourly) to 0 0 * * * (midnight daily) to match Vercel Hobby plan limits.
- Add .github/FUNDING.yml to show Sponsor button on repo - Add sponsor badge, link, and tier table to README - Add .vercel and .env* entries to .gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…eeK/devtrack into fix/tab-active-indicator
|
@Priyanshu-byte-coder Updated the branch. Kindly review it once, it can be merged now. |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Hi @MaitrayeeK! The PR title says 'fix: improve AccountToggle active tab visibility' but the diff includes 50+ files — new API routes, SQL migrations, new components, e2e tests, CI workflow changes, and more. This is too large to review as a single PR and carries significant risk of breaking things.
Please split this into separate focused PRs:
- The AccountToggle tab visibility fix (CSS tweak in AccountToggle.tsx) — this is the actual fix stated in the title
- Any new features (repo analytics, wakatime sync, etc.) as separate PRs
The SQL migration file is especially risky in a bundled PR.
Thanks for understanding!
|
That happened because I merged the main branch into this branch. Closing this one and will raise another PR with only my issue-related changes. Thanks. |
Summary
Fixes the
AccountTogglecomponent where the active tab indicator was nearly invisible in light mode due to insufficient contrast between the active and inactive tab states.Closes #1037
Type of Change
Changes Made
[var(--card-muted)]and[var(--muted-foreground)]as a consistent reference surfaceHow to Test
Steps for the reviewer to verify this works:
Screenshots (if UI change)
Checklist
npm run lintpasses locallynpm run type-check)