fix: resolve playwright duplicate locators and patch legacy vitest flakes#1197
fix: resolve playwright duplicate locators and patch legacy vitest flakes#1197Logesh-Pro wants to merge 6 commits into
Conversation
…sync auth token scope
|
@Logesh-Pro is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
1426da7 to
3979153
Compare
|
This PR has a merge conflict with main. Please rebase your branch and resolve conflicts so we can merge it. |
3979153 to
5a491fa
Compare
Conflicts Resolved!I have successfully updated the branch with the latest upstream changes from All smoke tests and Vitest suites are verified and ready for your final review. Thanks again for assigning the intermediate milestones! |
8e90bbc to
5170655
Compare
5170655 to
ed99e37
Compare
|
I have cleanly merged the latest upstream updates from Ready for your final review and merge whenever you're free. Thanks |
|
Hi! This PR has been approved ( |
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
This PR includes pnpm-workspace.yaml and pnpm-lock.yaml — this project uses npm, not pnpm. Please remove those files before this can be merged.
The Playwright test renaming (adding [Landing E2E] prefix) and Vitest fixes are welcome — just remove the pnpm artifacts.
52f111b to
e795e66
Compare
|
Hello give me a time till 11 Pm I will resolve it
…On Thu, 28 May, 2026, 6:21 pm Priyanshu Doshi, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
This PR includes pnpm-workspace.yaml and pnpm-lock.yaml — this project
uses *npm*, not pnpm. Please remove those files before this can be merged.
The Playwright test renaming (adding [Landing E2E] prefix) and Vitest
fixes are welcome — just remove the pnpm artifacts.
—
Reply to this email directly, view it on GitHub
<#1197?email_source=notifications&email_token=BY34573MMTGQPXDFLSTXPFL45AY6PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYGEYDQMBXGUZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4381080753>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BY3457ZTF4V64AYUH4WNIUT45AY6PAVCNFSM6AAAAACZNPFPSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGOBRGA4DANZVGM>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BY34577IE7JN6CEFYE4DDLL45AY6PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYGEYDQMBXGUZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BY34573AY7V22XG43QCZHQL45AY6PA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYGEYDQMBXGUZ2M4TFMFZW63VGMFZXG2LHN2SWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Summary
This PR addresses and resolves the critical test duplication and locator errors that were causing automated smoke and e2e test runs to fail, while also patching flaky legacy setup scripts in the vitest suite.
Closes # [Insert Issue Number here if you have one, otherwise delete this line]
Type of Change
Changes Made
landing.spec.js): Resolved duplicate element locators blocking the landing page flow.StreakTracker.test.ts): Replaced direct assignment of the read-onlyglobal.navigatorobject with a safeObject.definePropertyconfiguration descriptor to prevent environment runtime assignment crashes. Updated test log titles to avoid CI duplication conflicts.auth.test.ts): Synchronized the expected NextAuth configuration provider scope validation string with the actual application output (read:user user:email read:discussion).How to Test
Steps for the reviewer to verify this works:
git checkout fix-smoke-testsnpx vitest run(280 tests should pass)npx playwright test e2e/landing.spec.js(4 tests should pass)Screenshots (if UI change)
N/A (Test suite and configuration updates only)
Checklist