refactor: rename storage services by pbrassel · Pull Request #104 · PrivateAIM/helm

pbrassel · 2026-02-09T13:32:09Z

Rename node-result-service to node-storage-service

Summary by CodeRabbit

Refactor
- Renamed service references from result-service to storage-service across Helm charts and Kubernetes manifests, including service, deployment, probes, labels, and values.
- Updated UI component labels for consistency.
- Updated Hub adapter references to use the storage service.
Documentation
- Added v0.0.11 entry to the changelog documenting the renaming.

coderabbitai · 2026-02-09T13:32:29Z

📝 Walkthrough

Walkthrough

Refactors the Helm chart and related manifests by renaming the "result-service" to "storage-service" throughout metadata, labels, container names, ports, image references, probes, and values; adds a CHANGELOG entry for v0.0.11. No functional logic changes introduced.

Changes

Cohort / File(s)	Summary
Changelog `CHANGELOG.md`	Added v0.0.11 entry documenting the rename/refactor from node-result-service to node-storage-service.
Helm helpers `charts/flame-node/templates/_helpers.tpl`	Comment label changed from "Result Service helpers" to "Storage Service helpers".
Storage service manifests `charts/flame-node/templates/storage-service/deployment.yaml`, `charts/flame-node/templates/storage-service/service.yaml`	Renamed resources, labels, selectors, container name, ports, env references, probes, image and imagePullPolicy keys from resultService → storageService and updated component/app labels accordingly.
Hub adapter deployment `charts/flame-node/templates/hub-adapter/deployment.yaml`	Changed RESULTS_SERVICE_URL reference to point at the storage service variant.
UI manifests `charts/flame-node/templates/ui/deployment.yaml`, `charts/flame-node/templates/ui/ingress.yaml`, `charts/flame-node/templates/ui/service.yaml`	Updated UI-related labels/selectors from `flame-node-ui` to `flame-ui` for metadata, selectors, and pod labels.
Values files `charts/flame-node/values.yaml`, `charts/flame-node/values_min.yaml`	Renamed top-level key `resultService` → `storageService`; updated image repository/tag to `node-storage-service` and probe port names; adjusted comments and hub auth wording; updated hubAdapter image tag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

I nibbled through templates, soft and merry,
Swapped "result" for "storage" in every directory,
Labels aligned, images retagged with care,
A rabbit's refactor — light as air! 🐇✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Storage service' directly relates to the main objective of the changeset, which is to rename node-result-service to node-storage-service across Helm charts and configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch storage-service

No actionable comments were generated in the recent review. 🎉

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

charts/flame-node/values.yaml (1)

185-199: ⚠️ Potential issue | 🟠 Major

Breaking values key rename needs a migration path.

Renaming resultService → storageService will cause existing user overrides to be ignored on upgrade. Consider adding a backward-compatible alias or explicitly calling this out as a breaking change in upgrade notes (and versioning accordingly).

🤖 Fix all issues with AI agents

In `@charts/flame-node/templates/storage-service/service.yaml`:
- Line 4: The templated service name scalar is unquoted and causing YAML lint
errors; update the service metadata name value (the "name:" entry in the service
template) to use a quoted string around the template expression (e.g., wrap the
existing {{ .Release.Name }}-node-storage-service value in double quotes) so the
YAML parser treats it as a single scalar.

coderabbitai · 2026-02-09T13:36:00Z

charts/flame-node/templates/storage-service/service.yaml

 kind: Service
 metadata:
-  name: {{ .Release.Name }}-node-result-service
+  name: {{ .Release.Name }}-node-storage-service


⚠️ Potential issue | 🟠 Major

Fix YAML linting by quoting the templated name.

YAMLlint reports a syntax error here; quoting the template scalar usually resolves it.

Suggested fix

- name: {{ .Release.Name }}-node-storage-service + name: "{{ .Release.Name }}-node-storage-service"

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

name: {{ .Release.Name }}-node-storage-service

name: "{{ .Release.Name }}-node-storage-service"

🧰 Tools

🪛 YAMLlint (1.38.0)

[error] 4-4: syntax error: expected , but found ''

(syntax)

🤖 Prompt for AI Agents

In `@charts/flame-node/templates/storage-service/service.yaml` at line 4, The templated service name scalar is unquoted and causing YAML lint errors; update the service metadata name value (the "name:" entry in the service template) to use a quoted string around the template expression (e.g., wrap the existing {{ .Release.Name }}-node-storage-service value in double quotes) so the YAML parser treats it as a single scalar.

brucetony · 2026-02-10T10:22:22Z

charts/flame-node/templates/hub-adapter/deployment.yaml

              value: {{ .Values.proxy.noProxy | default "" }}
            - name: RESULTS_SERVICE_URL
-              value: {{ printf "http://%s-node-result-service.%s.svc.cluster.local:8080" .Release.Name .Release.Namespace }}
+              value: {{ printf "http://%s-storage-service.%s.svc.cluster.local:8080" .Release.Name .Release.Namespace }}


I removed "node" from component names so that they are consistent between our components

brucetony · 2026-02-10T10:23:27Z

charts/flame-node/templates/storage-service/service.yaml

    - protocol: TCP
      port: 8080
-      targetPort: http-result-srv
+      targetPort: api


Port aliases can't be more than 15 characters and http-storage-srv is 16, so I changed it to a simpler name

brucetony · 2026-02-10T10:23:47Z

charts/flame-node/templates/ui/ingress.yaml

  labels:
-    component: flame-node-ui
-    app.kubernetes.io/name: flame-node-ui
+    component: flame-ui


Again removed "node" from component name for consistency

brucetony · 2026-02-10T10:25:08Z

charts/flame-node/values.yaml

+    repository: ghcr.io/privateaim/node-storage-service
    # Overrides the image tag whose default is the chart appVersion.
-    tag: 0.1.4
+    tag: sha-a8bd4f1


No official release yet so I had to use a sha, this needs to be replaced before merging

brucetony · 2026-02-10T10:25:44Z

charts/flame-node/values.yaml

    repository: ghcr.io/privateaim/node-hub-api-adapter
    # Overrides the image tag whose default is the chart appVersion.
-    tag: 0.4.1
+    tag: 0.4.2


This Hub adapter version includes the refactoring changes

brucetony

Two things need to happen before merging:

Image for storage service should be replaced in values.yaml to a version following SemVer
Have to wait for a new PO release which uses the new component name flame-storage-service otherwise the nginx sidecar container fails when starting analyses. Here is the issue tracking this request: PrivateAIM/node-pod-orchestration#39

pbrassel added 2 commits February 9, 2026 14:27

refactor: rename node-result-service to node-storage-service

14b6f91

docs: update changelog

3ffec1d

pbrassel requested a review from brucetony February 9, 2026 13:32

coderabbitai bot reviewed Feb 9, 2026

View reviewed changes

brucetony added 3 commits February 10, 2026 10:50

refactor(node): change storage port and component names

bfc9a9e

chore(node): update hub adapter image for new storage service

0c13835

refactor(node): standardize node ui names

016a4b8

brucetony reviewed Feb 10, 2026

View reviewed changes

brucetony mentioned this pull request Feb 10, 2026

Update component name for new storage service PrivateAIM/node-pod-orchestration#39

Open

brucetony requested changes Feb 10, 2026

View reviewed changes

Merge branch 'master' into storage-service

6c8d857

tada5hi changed the title ~~Storage service~~ refactor: rename storage services Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: rename storage services#104

refactor: rename storage services#104
pbrassel wants to merge 6 commits intomasterfrom
storage-service

pbrassel commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 9, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Feb 9, 2026

Uh oh!

brucetony Feb 10, 2026

Uh oh!

brucetony Feb 10, 2026

Uh oh!

brucetony Feb 10, 2026

Uh oh!

brucetony Feb 10, 2026

Uh oh!

brucetony Feb 10, 2026

Uh oh!

brucetony left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	name: {{ .Release.Name }}-node-storage-service
	name: "{{ .Release.Name }}-node-storage-service"

Conversation

pbrassel commented Feb 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

brucetony left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pbrassel commented Feb 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 9, 2026 •

edited

Loading