Add commands workflow#727
Conversation
| token: ${{ secrets.PAT_PASSWORD }} | ||
| # See `Options` section below for more info on these options | ||
| install-command: npm install | ||
| /fixlint.fix-command: npm run fix |
There was a problem hiding this comment.
are you sure this will work here?
mcdata is a bit different from all other repos
there's tools/js for package.json stuff
and for releases there's only HISTORY.md , no package.json
There was a problem hiding this comment.
Yeah, the package.json is optional, it can read the version from just the history extremeheat#17
There was a problem hiding this comment.
how does it know where to run npm run fix ?
There was a problem hiding this comment.
It runs the commands specified in the workflow options at the root of the repo. But yeah it was missing the “cd tools/js” step, fixed that in the workflow options
|
nice, seems to work maybe let's add it in prismarine template |
|
btw I created #728 to issue the commands does that make sense? should we do this everywhere? |
|
Yeah, it can be added probably to most of the repos. It's not required to make a new issue, it should work in any issue or PR comment if the user is the author or has commit permissions on the repo. |
2 participants
No description provided.