Add Minecraft 26.1.2 data#1186
Conversation
…fix LpVec3 + use_entity Replaces our Siigari-PR-PrismarineJS#1184-derived protocol.json with mneuhaus's PR PrismarineJS#1186 (PrismarineJS#1186, head bc0c595, opened 2026-05-12, 49 mineflayer external tests passing). ROOT CAUSE (bytecode-verified 2026-05-12): - MC 26.1.2 server-26.1.2.jar contains new class net/minecraft/network/LpVec3.class - ClientboundSetEntityMotionPacket.STREAM_CODEC <clinit>+8 reads via net/minecraft/world/phys/Vec3.LP_STREAM_CODEC → BootstrapMethods table cites LpVec3.read/write - Our prior schema mistyped packet_entity_velocity.velocity, packet_spawn_entity.velocity, and packet_use_entity.location as vec3i16 (3 × i16 = 6 bytes, notch-quantized) when wire format is actually LpVec3 (variable-length bit-packed with scale bits + continuation flag + optional VarInt extension) - Byte-coincident wire size (6 bytes minimum LpVec3) → packet parses without PartialReadError but values are garbage → mineflayer applies garbage to bot.entity.velocity → physics integration → "10× knockback catapult" symptom (bot launched 60+ blocks, dies on fall) FIX (this commit): - packet_entity_velocity.velocity: vec3i16 → lpVec3 - packet_spawn_entity.velocity: vec3i16 → lpVec3 - packet_use_entity: rewritten (entityId + hand + location: lpVec3 + usingSecondaryAction) - Many adjacent shapes updated to match upstream-canonical 26.1.2 schema - Codec (lpVec3.js) already in node-minecraft-protocol@1.66.0; no new protodef type needed Spec: docs/superpowers/specs/2026-05-12-mc26-protocol-schema-audit-design.md Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
This looks LLM generated, did you review these changes? There are several unrelated changes to the protocol and the PR to jar extractor doesn't look right as we don't use that anymore in favor of the minecraft-data-generator mod (see update doc) Also, we have a automated scaffolded PR in #1160, this correctly runs the |
|
Hey, yes as i put into the Implementation Note at the end of all PRs i did do this with Codex (GPT 5.5), i did look over the Pull-Requests but i'm obviously not as deep into this whole codebase so i could have easily missed something. Also did not see/know about stuff going against that PR branch, i can rework this as needed if you like. If you don't want any LLM contrib here i can also cancel/close the Pull-Requests. |
2 participants
Summary
Adds Minecraft 26.1.2 data, including protocol data and generated block/item/particle/material/food/recipe data for the release.
The generated block and item data are needed for correct 26.1.2 state IDs and item IDs. This fixed downstream Mineflayer external failures around beds, furnaces, crafting, particles and other item/block assumptions.
Testing
Validated through node-minecraft-data and Mineflayer downstream checks:
Evidence summary: https://gist.github.com/mneuhaus/decaae9cd8767a651272d31cdf97ac60
Related PRs
Part of the Minecraft 26.1.2 update chain:
The dependent PRs are opened as drafts so they can be reviewed/merged in order.
Implementation note
Prepared with assistance from GPT-5.5 and validated locally with the checks listed above.