ContactForm: Hide subject dropdown when only one contact is available#201
Merged
Hlavtox merged 2 commits intoPrestaShop:developfrom Mar 25, 2026
Merged
Conversation
Touxten
previously approved these changes
Feb 12, 2026
tblivet
previously approved these changes
Feb 17, 2026
Codencode
force-pushed
the
contactform-hide-subject-when-single-contact
branch
from
3fc03bb to
5ba3b06
Compare
tblivet
approved these changes
Feb 17, 2026
Touxten
approved these changes
Feb 28, 2026
Contributor
Author
|
@PrestaShop/committers can someone explain to me why the Waiting for QA label was removed? |
Touxten
added
the
Waiting for QA
Contributor
|
Good Question |
Contributor
Author
|
Probably ps-jarvis has some bug 😄 |
|
Hello @Codencode, Thanks for your PR, i tested it and it's good for me ^^ Enregistrement.de.l.ecran.2026-03-25.a.15.41.34.movThanks |
SiraDIOP
approved these changes
Mar 25, 2026
SiraDIOP
added
QA ✔️
|
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
Contributor
|
Thanks everyone!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of rendering a
<select>with a single option, the module now automatically sets theid_contactvalue using a hidden input.This improves the user experience by removing an unnecessary selection while preserving the expected form behavior.
- Delete the contacts, leaving only one
- In the front office, go to the Contact page
- The
Subject Headinglabel and its related select dropdown should not be displayedBefore
After