Foss sandbox#41
Merged
Merged
Conversation
…ed SMB_NAME type Agent-Logs-Url: https://github.com/Pressingly/plane/sessions/35f3c0a2-8cd0-497a-a94b-9fd4c0d8e2dd Co-authored-by: jawad-khan <5320368+jawad-khan@users.noreply.github.com>
…tings Hide profile Security tab and Deactivate account for SSO (VITE_AUTH_TYPE=SSO)
There was a problem hiding this comment.
Pull request overview
This PR introduces an SSO-build feature flag helper for the web app and uses it to hide/disable account security and deactivation UI when the build is configured for SSO authentication.
Changes:
- Added a shared
isSsoAuth()helper (based onVITE_AUTH_TYPE) and refactored onboarding to use it. - Hid the Profile “Security” tab in the sidebar and prevented opening it via modal/route when in SSO builds.
- Hid the “Deactivate account” UI in profile general settings for SSO builds, and added a TS global type shim for
process.envusage in Vite builds.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/vite-process-env.d.ts | Adds TS global typing for process.env which is injected/replaced via Vite define. |
| apps/web/helpers/auth-config.helper.ts | Introduces shared isSsoAuth() helper for consistent SSO-build gating. |
| apps/web/core/components/settings/profile/sidebar/item-categories.tsx | Filters out the “security” tab from the profile settings sidebar when SSO is enabled. |
| apps/web/core/components/settings/profile/modal.tsx | Prevents the profile settings modal from opening directly on the “security” tab in SSO builds. |
| apps/web/core/components/settings/profile/content/pages/general/form.tsx | Hides deactivate-account modal entry point and section in SSO builds. |
| apps/web/core/components/onboarding/steps/profile/root.tsx | Refactors onboarding “optional password” gating to use the shared SSO helper. |
| apps/web/core/components/onboarding/profile-setup.tsx | Refactors onboarding “optional password” gating to use the shared SSO helper. |
| apps/web/app/(all)/settings/profile/[profileTabId]/page.tsx | Redirects /settings/profile/security to /settings/profile/general in SSO builds. |
aznszn
approved these changes
Jun 2, 2026
hunzlahmalik
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description