Skip to content

🐛 Clear X-Forwarded-Host when proxying asset storage requests#27

Merged
UsamaSadiq merged 1 commit into
foss-mainfrom
fix/asset-route
May 20, 2026
Merged

🐛 Clear X-Forwarded-Host when proxying asset storage requests#27
UsamaSadiq merged 1 commit into
foss-mainfrom
fix/asset-route

Conversation

@aznszn

@aznszn aznszn commented May 20, 2026

Copy link
Copy Markdown

Summary

  • Adds proxy_set_header X-Forwarded-Host ""; in the nginx asset proxy block
  • Prevents the public-facing hostname from leaking through to S3/MinIO
  • S3-compatible stores were honoring X-Forwarded-Host over the correctly-set Host header, causing thumbnail requests to be rejected or misrouted

Test plan

  • Open a Penpot file with existing thumbnails — confirm they render
  • Upload a new image asset — confirm thumbnail appears in the asset panel
  • Check nginx/storage logs for no hostname mismatch errors

🤖 Generated with Claude Code

@aznszn aznszn force-pushed the fix/asset-route branch from f0135c6 to fddcf42 Compare May 20, 2026 06:29
@aznszn aznszn changed the title fix: clear X-Forwarded-Host when proxying asset storage 🐛 Clear X-Forwarded-Host when proxying asset storage requests May 20, 2026
@UsamaSadiq UsamaSadiq merged commit f22f3bb into foss-main May 20, 2026
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants