Add proper app icon for Electron desktop build#2
Open
AhtishamShahid wants to merge 8 commits into
Open
Conversation
Replace placeholder solid-blue square with the actual Open Notebook logo. Adds icon.png (1024x1024) for macOS and icon.ico (multi-size) for Windows.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Not needed for the desktop build — users update via the installer.
All PRs in this fork target release/** branches, not main. Add release/** to pull_request and push triggers so tests actually run.
- Remove updateAvailableDesc from all locales (orphaned when version check was removed) - Disable claude-code-review workflow (manual dispatch only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FOSSSMBBUN-113
Summary
icon.png(1024×1024) for macOS buildsicon.ico(multi-size: 16/32/48/64/128/256) for Windows buildsTest plan
npm run build:electroninelectron/) and verify the correct logo appears in the macOS dock and DMG windowicon.icocorrectly