A case study... #194
Merged
A case study... #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A case study of "test it if you expect it to work".
The conclusion of the case study.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happens when you assume and don't test what you build?
Did you answer, what you build doesn't work as expected? Good, you're better than me.
During the refactor the noxfile, I dropped the requirements being dynamically handled in the
pyproject.toml. Not seeing the trap I built for myself, I proceeded to build the noxfile with the impression that everything was working. Behold, folly. Not once did I notice I never installed therequirements.txtin the nox sessions. Something that is rather required if tests or linting is to pass.I even had taken a step toward avoiding the trap. I added
requeststo the dependency list "just to see it work". And then, like a silly-goose, I never actually used requests so my testing failed to produce the error that was inevitable.This has been my egg talk.