End of year clean up #177
Merged
End of year clean up #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version update (autoupdate) Remove hooks `debug-statements` and `mixed-line-endings` as rarely used.
Both `black` and `flake8` are enforced by pre-commit in the CI and are not requirements for developing. `mypy` remains here for support of editor setups that have extensions to use mypy while working but require the library to be installed.
Use the venv `--update-deps` flag to ensure pip is updated when a new venv is created.
Allow line lengths of 100 for black and remove flake8's config on length. flake8 is already configured to ignore line length violations. Reasoning of 100: A line length of 88 is the default which is 8 more than PEP-8 recommendations. This comes from the default recommendation plus two indents worth which amount to a class and method. 100 allows for three more indents. The goal here is not to encourage deeper nesting but to encourage more verbose naming without trying to trim those few characteres. Overall expectation is to keep using a visual guide of 88 characters.
Adds the flag `include-hidden-files: true` to the upload artifact action as behavior was changed in 4.4.1.
Preocts
added a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.