userGcCohorts output object added; userGcSPU marked as depreciating

[suz-estella]

Getting this started: PredictiveEcology/CBM_vol2biomass#37

The userGcSPU object is still being created so everything will still work for now but this makes it so CBM_vol2biomass can be updated at any time.

What do we think about the name userGcCohorts? I also thought userGcCombos could work. This table has the columns juris_id, ecozone, and and columns in sim$curveID.

[cboisvenue]

Looks great. I would suggest not using the work cohort in the name. That is not a very common concept. How about userGcID? or are we already using that? To me the "ID" part tells me that it links the growth curve IDs to something. Let me know what you think.

[suz-estella]

My only concern with that is it might get confused with the gcids column or the concept of the curveID. If I were to describe this entity: It's a table containing every combination of locational info (juris_id and ecozone) with a growth curve that exists within the study area. The gcids column is not present in it - it gets created from it later.

Just brainstormin' more ideas:

• userGcEco
• userGcEcoCombos
• userGcStudyArea
• userGcInStudyArea
• userGcLocations

[camillegiuliano]

I agree that userGcID would be confusing given how we already use gcid elsewhere.
Of the ideas listed I personally prefer userGcLocations for this table.

[cboisvenue]

Ok, userGcLocations sounds good to me too.

[suz-estella]

@cboisvenue I just overwrote the commit to have the object named as userGcLocations instead. Will be good to merge if tests pass :)