desktop: fix .rstrip(".git") mangling node names ending in g/i/t/.#7
Open
PozzettiAndrea wants to merge 1 commit into
Open
desktop: fix .rstrip(".git") mangling node names ending in g/i/t/.#7PozzettiAndrea wants to merge 1 commit into
PozzettiAndrea wants to merge 1 commit into
Conversation
str.rstrip takes a set of chars to strip, not a suffix -- so
"ComfyUI-UniRig.git".rstrip(".git") yields "ComfyUI-UniR" (the trailing
"ig" gets eaten after .git). Every downstream fetch
(pyproject.toml, comfy-test.toml, workflows/) then 404s on the
mangled URL and the run reports "no workflows ran" with rc=0.
Use str.removesuffix(".git") so only the actual ".git" suffix is
trimmed. Manifested on UniRig (ends in 'g') -- would also break any
node ending in g/i/t/. (e.g. *-Lit, *-Edit, *-Pi).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str.rstrip(".git")strips ANY trailing chars in{'.','g','i','t'}, not the literal.gitsuffixComfyUI-UniRig.gitit yieldsComfyUI-UniR, so every downstream fetch (pyproject.toml, comfy-test.toml, workflows/) 404s--desktopruns report "no workflows ran" but exit rc=0 (a fake-pass)str.removesuffix(".git")(Python 3.9+, project already pins>=3.10)Symptom
Run 25641163916 — UniRig windows-desktop CPU. Log shows:
```
[desktop] node: ComfyUI-UniR (URL: .../ComfyUI-UniR, branch: main, ...)
[ 313s] ext: pyproject.toml fetch/parse failed: HTTP Error 404
[ 329s] ext: tile not found, ending capture
[ 330s] videos/system/driver.mp4 placed (no workflows ran)
```
Test plan
{g,i,t,.}(none currently affected besides UniRig)🤖 Generated with Claude Code