Feature/minio and milvus #141
Conversation
…tion for MinIO and Milvus integration. Update templates to ensure Milvus deployment is contingent on MinIO being enabled. Introduce MinIO client setup for automatic bucket creation.
There was a problem hiding this comment.
Pull request overview
This PR adds support for MinIO and Milvus deployments to the Portkey Gateway Helm chart, enabling in-cluster object storage and vector database capabilities for semantic caching.
Changes:
- Added MinIO StatefulSet, Service, and Secret templates for in-cluster object storage
- Added Milvus StatefulSet, Service, and ConfigMap templates with etcd dependency for vector database
- Added comprehensive documentation for MinIO and Milvus configuration
- Updated values.yaml with configuration options for MinIO, Milvus, and etcd images
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/portkey-gateway/values.yaml | Adds image definitions and configuration sections for MinIO, etcd, and Milvus |
| charts/portkey-gateway/templates/minio/statefulset.yaml | Creates MinIO StatefulSet with sidecar client container for bucket initialization |
| charts/portkey-gateway/templates/minio/service.yaml | Exposes MinIO API and console ports via ClusterIP service |
| charts/portkey-gateway/templates/minio/secret.yaml | Manages MinIO access credentials as a Kubernetes Secret |
| charts/portkey-gateway/templates/milvus/milvus-statefulset.yaml | Deploys Milvus vector database with MinIO and etcd dependencies |
| charts/portkey-gateway/templates/milvus/milvus-service.yaml | Exposes Milvus gRPC and HTTP endpoints |
| charts/portkey-gateway/templates/milvus/milvus-config.yaml | Configures Milvus authorization settings |
| charts/portkey-gateway/templates/milvus/etcd-statefulset.yaml | Deploys etcd as metadata store for Milvus |
| charts/portkey-gateway/templates/milvus/etcd-service.yaml | Exposes etcd client port for Milvus connectivity |
| charts/portkey-gateway/templates/_helpers.tpl | Adds label and selector helpers for MinIO, Milvus, and etcd resources |
| charts/portkey-gateway/docs/VectorStore.md | Documents Milvus setup and semantic cache configuration |
| charts/portkey-gateway/docs/MinioConfiguration.md | Documents MinIO deployment configuration |
| charts/portkey-gateway/docs/Configuration.md | Adds reference documentation for new configuration parameters |
| charts/portkey-gateway/README.md | Updates main documentation with MinIO log store option and vector store reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…eys for clarity. Adjust templates to reflect new key names for MinIO credentials.
avaya09
force-pushed
the
feature/minio-and-milvus
branch
from
c1f3e36 to
c30b2f9
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…he documentation and key reference for clarity.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ntation references and repository path for MinIO image.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.