fix: --ascending flag made explicit, default descending#33
Closed
LeeHengYu wants to merge 1 commit intoPolymarket:mainfrom
Closed
fix: --ascending flag made explicit, default descending#33LeeHengYu wants to merge 1 commit intoPolymarket:mainfrom
--ascending flag made explicit, default descending#33LeeHengYu wants to merge 1 commit intoPolymarket:mainfrom
Conversation
LeeHengYu
changed the title
LeeHengYu
changed the title
--ascending flag made explicit, default descending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
Patching PR #20 #31, related to #26
The default behavior of descending sort remains (no ascending flag), fix up all instances to
maybe_ascending(Some(ascending))across all 6 references.Note
Low Risk
Small, mechanical change limited to query parameter construction for list endpoints; no auth, persistence, or data mutation paths are affected.
Overview
Fixes sorting behavior in CLI list commands by always forwarding the
ascendingflag into the SDK request builders (maybe_ascending(Some(ascending))) instead of only setting it when--ascendingis true.This updates the request construction for comments, events, markets, series, sports teams, and tags so ascending/descending ordering is applied consistently.
Written by Cursor Bugbot for commit dcbc50b. This will update automatically on new commits. Configure here.