Zizmor Updates #16
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
Code Review
This PR refactors the 'Pull Request Preview' action by pinning GitHub Actions to specific SHAs for security, improving environment variable handling in shell scripts to prevent injection, and moving the PR commenting logic into a separate JavaScript file. Feedback includes correcting misleading version comments for pinned actions, adding validation for the deployment URL, replacing the hardcoded bot ID with a more robust identification method, and adding safety checks for the PR payload to prevent runtime errors on non-PR events.
whats new
moved the js parts out of yaml, updated release yaml and introduced zizmor workflow. also updated action file according to zizmor warnings