fix: allow GitHub OAuth users to change password#419
Open
Conversation
joshuagraber
reviewed
Mar 2, 2026
Collaborator
joshuagraber
left a comment
joshuagraber
left a comment
There was a problem hiding this comment.
This PR seems to have a lot of unrelated file changes, making it hard to review the OAuth updates specifically.
@maxachis Are some of these changes meant to address other issues?
maxachis
force-pushed
the
issue/279-update-change-password-route
branch
from
2d37ae0 to
e4dc361
Compare
Remove the OAuth gating that hid the password change form from GitHub-linked users. Users who signed up with email and later linked GitHub may still have a password to change. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maxachis
force-pushed
the
issue/279-update-change-password-route
branch
from
e4dc361 to
83b13ec
Compare
Verify the password change form renders unconditionally — no longer gated behind an OAuth check. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
@joshuagraber Nah, it was me branching off main instead of dev. That's what I get for Claude Coding indiscreetly! I've adjusted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/change-passwordthat blocked GitHub-linked users from seeing the password change formuseQuery/getUser/PROFILEimports that were only needed for the OAuth checkCloses #279
Test plan
npx vitest run)🤖 Generated with Claude Code