Conversation
542f5f9 to
38a2e3d
Compare
joshuagraber
left a comment
There was a problem hiding this comment.
Looks good, but I think e2e is a better strategy for validating this with testing.
There was a problem hiding this comment.
I don't know that a test on constants is useful here. The validator logic is tested in design system, the constant should be its own source of truth. I think we'd get more value from end-to-end test validation if we want to ensure that the error message that shows up in the working system is what we expect.
@joshuagraber Excellent point! We do have |
I think so, @maxachis, but if not, we can certainly add or update those test cases to ensure they're covering everything. |
…eation (#310) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validator logic is already tested in the design system. The constants file is its own source of truth and doesn't benefit from a unit test that just re-asserts its values. E2e tests already cover form validation behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
b98f464 to
3accd99
Compare
Summary
creation form, so users get immediate feedback instead of a generic API error when
exceeding the limit
testability and reuse
Closes #310
Test plan
characters, confirm the validation message "Title must be 255 characters or fewer."
appears before submission