fix: mock email/password login in E2E tests#413
Merged
Conversation
Add MSW handler for POST /auth/login so auth-dependent E2E tests no longer hit the real API. This fixes two issues: fork PRs failing because GitHub Actions doesn't expose secrets, and flaky timeouts from slow external API responses. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@joshuagraber Two things!
|
Collaborator
|
@maxachis Yes, I think this strategy should be okay, as long as it doesn't result in any downstream effects in other e2e. Yeah, the tests have been pretty flaky, and some of them are downright unreliable. I think a general issue to look into that would be a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /auth/loginthat returns mock JWT tokens for valid credentials and 401 for invalid onesAUTH_BASE_URLfrome2e/fixtures/constants.jsfor the new handlerThis eliminates the dependency on real API credentials and external API availability for auth-dependent E2E tests, addressing two failure modes:
signInWithPasswordAPI calls sometimes exceed the 30s timeoutTest plan
npx playwright test e2e/auth/sign-in.spec.js— all 5 tests passnpx playwright test e2e/data-request/create.spec.js e2e/data-source/create.spec.js— 8/9 pass (1 pre-existing flaky failure from realPOST /data-requestsAPI, not auth-related)🤖 Generated with Claude Code